lint based on configArray item.files

Signed-off-by: Charlike Mike Reagent <[email protected]>
helapkg · Mar 8, 2020 · 578fdf3 · 578fdf3
1 parent 9b8053c
commit 578fdf3
Show file tree

Hide file tree

Showing 6 changed files with 412 additions and 135 deletions.
diff --git a/eslint.config.js b/eslint.config.js
@@ -1,52 +1,23 @@
-'use strict';
-
-// module.exports = {
-//   name: "name",
-//   files: ["*.js"],
-//   ignores: ["*.test.js"],
-//   settings: {},
-//   languageOptions: {
-//       ecmaVersion: 2020,
-//       sourceType: "module",
-//       globals: {},
-//       parser: object || "string",
-//       parserOptions: {},
-//       linterOptions: {
-//           reportUnusedDisableDirectives: "string"
-//       }
-//   }
-//   processor: object || "string",
-//   plugins: {}
-//   rules: {}
-// };
-
-const {
-  DEFAULT_FILES,
-  DEFAULT_IGNORE,
-} = require('./packages/eslint/src/constants');
-
 module.exports = [
-  /*
-    gets converted to
-
-    {
-      plugins: {
-        'eslint:recommended': require('somehow-load-eslint-internal-rules')
-      }
-    }
-   */
-  // 'eslint:recommended',
   {
     name: 'loading-babel-eslint-parser-through-custom-plugin',
     plugins: {
       'custom-plugin': require('./custom-eslint-plugin'),
     },
   },
 
-  // consider linting src/index.jsx - both configs should apply for it
-  // so, what will the ConfigArray#getConfig(filename) return??
+  // example using the custom loaded parser
+  {
+    languageOptions: {
+      // directly requiring the parser
+      // parser: require('babel-eslint'),
+
+      // or: through the loaded plugin
+      parser: 'custom-plugin/eslint-esnext',
+    },
+  },
   {
-    files: '**/*.{js,jsx}',
+    files: 'packages/*/src/**/*.js',
     plugins: {
       unicorn: require('eslint-plugin-unicorn'),
     },
@@ -57,7 +28,7 @@ module.exports = [
     },
   },
   {
-    files: '**/*.jsx',
+    files: '**/__tests__/**/*.{js,jsx}',
     plugins: {
       react: require('eslint-plugin-react'),
     },
@@ -66,34 +37,4 @@ module.exports = [
       'global-require': 'error',
     },
   },
-
-  {
-    name: 'some-tunnckocore-config',
-    files: DEFAULT_FILES,
-    ignores: DEFAULT_IGNORE,
-    languageOptions: {
-      globals: {},
-      // directly requiring the parser
-      // parser: require('babel-eslint'),
-
-      // or: through the loaded plugin
-      parser: 'custom-plugin/eslint-esnext',
-
-      // or require-ing of the plugin directly
-      // parser: require('./custom-eslint-plugin').parsers['eslint-esnext'],
-      parserOptions: {
-        ecmaVersion: 2020,
-        sourceType: 'module',
-        ecmaFeatures: {
-          generators: false,
-          objectLiteralDuplicateProperties: false,
-        },
-      },
-    },
-    plugins: {},
-    rules: {
-      semi: ['error', 'always'],
-      'global-require': ['error', 'always'],
-    },
-  },
 ];
diff --git a/origin-eslint.config.js b/origin-eslint.config.js
@@ -0,0 +1,99 @@
+'use strict';
+
+// module.exports = {
+//   name: "name",
+//   files: ["*.js"],
+//   ignores: ["*.test.js"],
+//   settings: {},
+//   languageOptions: {
+//       ecmaVersion: 2020,
+//       sourceType: "module",
+//       globals: {},
+//       parser: object || "string",
+//       parserOptions: {},
+//       linterOptions: {
+//           reportUnusedDisableDirectives: "string"
+//       }
+//   }
+//   processor: object || "string",
+//   plugins: {}
+//   rules: {}
+// };
+
+const {
+  DEFAULT_FILES,
+  DEFAULT_IGNORE,
+} = require('./packages/eslint/src/constants');
+
+module.exports = [
+  /*
+    gets converted to
+
+    {
+      plugins: {
+        'eslint:recommended': require('somehow-load-eslint-internal-rules')
+      }
+    }
+   */
+  // 'eslint:recommended',
+  {
+    name: 'loading-babel-eslint-parser-through-custom-plugin',
+    plugins: {
+      'custom-plugin': require('./custom-eslint-plugin'),
+    },
+  },
+
+  // consider linting src/index.jsx - both configs should apply for it
+  // so, what will the ConfigArray#getConfig(filename) return??
+  {
+    files: '**/*.{js,jsx}',
+    plugins: {
+      unicorn: require('eslint-plugin-unicorn'),
+    },
+    rules: {
+      'unicorn/no-process-exit': ['error'],
+      'unicorn/consistent-function-scoping': 'error',
+      semi: 'error',
+    },
+  },
+  {
+    files: '**/*.jsx',
+    plugins: {
+      react: require('eslint-plugin-react'),
+    },
+    rules: {
+      'react/jsx-uses-react': 'error',
+      'global-require': 'error',
+    },
+  },
+
+  {
+    name: 'some-tunnckocore-config',
+    files: DEFAULT_FILES,
+    ignores: DEFAULT_IGNORE,
+    languageOptions: {
+      globals: {},
+      // directly requiring the parser
+      // parser: require('babel-eslint'),
+
+      // or: through the loaded plugin
+      parser: 'custom-plugin/eslint-esnext',
+
+      // or require-ing of the plugin directly
+      // parser: require('./custom-eslint-plugin').parsers['eslint-esnext'],
+      parserOptions: {
+        ecmaVersion: 2020,
+        sourceType: 'module',
+        ecmaFeatures: {
+          generators: false,
+          objectLiteralDuplicateProperties: false,
+        },
+      },
+    },
+    plugins: {},
+    rules: {
+      semi: ['error', 'always'],
+      'global-require': ['error', 'always'],
+    },
+  },
+];
diff --git a/packages/eslint/__tests__/index.js b/packages/eslint/__tests__/index.js
@@ -3,7 +3,7 @@
 const mod = require('../src/index');
 
 test('todo test for mod', () => {
-  // const foo = 123;x
+  const foo = 123;
   expect(typeof mod).toStrictEqual('object');
   expect(typeof mod.helaCommand).toStrictEqual('function');
 });