Skip to content

fix(transactions): surface confirmation errors immediately#183

Merged
0xIchigo merged 1 commit intohelius-labs:devfrom
pradhankukiran:fix/confirmation-errors-surface-immediately
Mar 13, 2026
Merged

fix(transactions): surface confirmation errors immediately#183
0xIchigo merged 1 commit intohelius-labs:devfrom
pradhankukiran:fix/confirmation-errors-surface-immediately

Conversation

@pradhankukiran
Copy link
Copy Markdown
Contributor

Summary

  • retry transaction confirmation only when the inner poll times out
  • return deterministic on-chain failures and other non-timeout confirmation errors immediately
  • add a regression test for the retry classification and note the fix in the changelog

Validation

  • cargo fmt
  • cargo test
  • cargo clippy

Copy link
Copy Markdown
Collaborator

@0xIchigo 0xIchigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very based! Thank you for your contribution! 🔥

@0xIchigo 0xIchigo merged commit 369355a into helius-labs:dev Mar 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants