-
Notifications
You must be signed in to change notification settings - Fork 11
manifest: Update to NCS 3.1.0 #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1c9f4ec
to
a50a1c0
Compare
34b9d4c
to
f3fc991
Compare
We need this change as well after an upstream change to zbus
|
f3fc991
to
a32b6a6
Compare
Update to NCS 3.1.0. Signed-off-by: Jorgen Kvalvaag <[email protected]>
a32b6a6
to
4068b1c
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the project from NCS (Nordic Connect SDK) version 2.8.0-rc2 to version 3.1.0, involving API changes and configuration updates to maintain compatibility with the newer SDK version.
- Updates SDK version in manifest from v2.8.0-rc2 to v3.1.0
- Adapts to zbus API changes by removing timeout parameters and using K_NO_WAIT
- Updates NPM1300 charger driver references to NPM13XX and adapts API calls
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
west.yml | Updates NCS SDK version from v2.8.0-rc2 to v3.1.0 |
app/src/modules/trigger/trigger.c | Removes timeout parameters from trigger_send function and zbus calls |
app/src/modules/battery/battery.c | Updates NPM1300 driver includes and API calls to NPM13XX equivalents |
app/sample.yaml | Removes CONFIG_BUILD_S1_VARIANT build configuration |
app/prj.conf | Updates multiple configuration options for NCS 3.1.0 compatibility |
app/overlay-etb.conf | Reduces Memfault storage partition size |
app/Kconfig.sysbuild | Adds new sysbuild configuration file |
app/Kconfig | Adds TFM SRAM partition size configuration |
.github/workflows/build.yml | Removes CONFIG_BUILD_S1_VARIANT from build commands |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@@ -233,7 +233,7 @@ static void sample(int64_t *ref_time) | |||
NPM1300_CHG_STATUS_CC_MASK | | |||
NPM1300_CHG_STATUS_CV_MASK)) != 0; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nrf_fuel_gauge_process function call has been modified to remove a boolean parameter and replace it with NULL. This appears to be an API change, but without documentation of what the removed parameter represented, this change could affect fuel gauge behavior. Consider adding a comment explaining what functionality was removed or verify that NULL is the correct replacement for the boolean parameter.
Copilot uses AI. Check for mistakes.
Update to NCS 3.1.0.