Skip to content

Conversation

jorgenmk
Copy link
Contributor

@jorgenmk jorgenmk commented Sep 1, 2025

Update to NCS 3.1.0.

@jorgenmk jorgenmk force-pushed the update-ncs-3.1.0 branch 5 times, most recently from 1c9f4ec to a50a1c0 Compare September 1, 2025 12:38
Copilot

This comment was marked as outdated.

@jorgenmk jorgenmk force-pushed the update-ncs-3.1.0 branch 3 times, most recently from 34b9d4c to f3fc991 Compare September 1, 2025 13:21
@jtguggedal
Copy link
Contributor

We need this change as well after an upstream change to zbus

diff --git a/app/src/modules/trigger/trigger.c b/app/src/modules/trigger/trigger.c
index 4bcbbd1..7b519dc 100644
--- a/app/src/modules/trigger/trigger.c
+++ b/app/src/modules/trigger/trigger.c
@@ -136,7 +136,7 @@ static void frequent_poll_state_duration_timer_handler(struct k_timer * timer_id

       LOG_DBG("Frequent poll duration timer expired");

-       err = zbus_chan_pub(&PRIV_TRIGGER_CHAN, &unused, K_SECONDS(1));
+       err = zbus_chan_pub(&PRIV_TRIGGER_CHAN, &unused, K_NO_WAIT);
       if (err) {
               LOG_ERR("zbus_chan_pub, error: %d", err);
               SEND_FATAL_ERROR();

Update to NCS 3.1.0.

Signed-off-by: Jorgen Kvalvaag <[email protected]>
Copy link

sonarqubecloud bot commented Sep 2, 2025

@jorgenmk jorgenmk requested a review from Copilot September 2, 2025 08:41
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project from NCS (Nordic Connect SDK) version 2.8.0-rc2 to version 3.1.0, involving API changes and configuration updates to maintain compatibility with the newer SDK version.

  • Updates SDK version in manifest from v2.8.0-rc2 to v3.1.0
  • Adapts to zbus API changes by removing timeout parameters and using K_NO_WAIT
  • Updates NPM1300 charger driver references to NPM13XX and adapts API calls

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
west.yml Updates NCS SDK version from v2.8.0-rc2 to v3.1.0
app/src/modules/trigger/trigger.c Removes timeout parameters from trigger_send function and zbus calls
app/src/modules/battery/battery.c Updates NPM1300 driver includes and API calls to NPM13XX equivalents
app/sample.yaml Removes CONFIG_BUILD_S1_VARIANT build configuration
app/prj.conf Updates multiple configuration options for NCS 3.1.0 compatibility
app/overlay-etb.conf Reduces Memfault storage partition size
app/Kconfig.sysbuild Adds new sysbuild configuration file
app/Kconfig Adds TFM SRAM partition size configuration
.github/workflows/build.yml Removes CONFIG_BUILD_S1_VARIANT from build commands

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@@ -233,7 +233,7 @@ static void sample(int64_t *ref_time)
NPM1300_CHG_STATUS_CC_MASK |
NPM1300_CHG_STATUS_CV_MASK)) != 0;

Copy link
Preview

Copilot AI Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nrf_fuel_gauge_process function call has been modified to remove a boolean parameter and replace it with NULL. This appears to be an API change, but without documentation of what the removed parameter represented, this change could affect fuel gauge behavior. Consider adding a comment explaining what functionality was removed or verify that NULL is the correct replacement for the boolean parameter.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants