Spectral clustering: support pre-calculated affinity matrix, revamp API #1835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y_matrix_in_ht_cluster_Spectral
…D_based_on_Zolotarev-polar_decomposition' into features/1740-Support_pre-calculated_affinity_matrix_in_ht_cluster_Spectral
Contributor
|
Thank you for the PR! |
…y_matrix_in_ht_cluster_Spectral
…y_matrix_in_ht_cluster_Spectral
…y_matrix_in_ht_cluster_Spectral
…y_matrix_in_ht_cluster_Spectral
Contributor
|
Thank you for the PR! |
Contributor
Author
|
TODO:
|
Contributor
|
Thank you for the PR! |
Contributor
|
This pull request is stale because it has been open for 60 days with no activity. |
Contributor
Author
|
Update after #1964 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due Diligence
Description
This PR introduces some changes to the Spectral clustering class (see below), this work in connection with parallelization efforts of the SCIMES package with @dcolombo
Issue/s resolved: #1740
Changes proposed:
SpectralClustering(formerlySpectral) to match API of the current scikit-learn versionmetricparameter toaffinityto match sklearneigen_solver, with optionslanczosandzolotarev(Default:zolotarev) (e.g. Implement polar decomposition #1697 and Features/1723 Symmetric Eigenvalue Decomposition (eigh) and full SVD (svd) based on Zolotarev Polar Decomposition #1824 )n_components,random_stateto match scikit-learn API__spectral_embeddingis now just the embedding, like for scikit-learn (instead of eigenvalues and eigenvectors);DNDarray.diagonal()for convenience and to match numpy APIType of change
Memory requirements
NA
Performance
NA
Does this change modify the behaviour of other functions? If so, which?
no