Skip to content

Add support for complex64 in QR decomposition #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2400032275 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add support for complex64 in QR decomposition #2040

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff7a37c
Add support for complex64 in QR decomposition
2400032275 Nov 24, 2025
88c89dc
Fix syntax errors in QR decomposition complex64 support
2400032275 Nov 24, 2025
49665db
Merge branch 'main' into 2400032275-patch-1
2400032275 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions heat/core/linalg/qr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from ..manipulations import concatenate
from .. import factories
from .. import communication
from ..types import float32, float64
from ..types import float32, float64, complex64

__all__ = ["qr"]

Expand Down Expand Up @@ -94,11 +94,10 @@ def qr(
if procs_to_merge == 0:
procs_to_merge = A.comm.size

if A.dtype not in [float32, float64]:
if A.dtype not in [float32, float64, complex64]:
Copy link
Collaborator

@brownbaerchen brownbaerchen Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better check would be

from ..types import issubdtype, floating, complex
if not issubdtype(A.dtype, floating) and not issubdtype(A.dtype, complex):

which would automatically work with all precision versions of these types. In particular, ones that will be added in the future.

raise TypeError(f"Array 'A' must have a datatype of float32 or float64, but has {A.dtype}")

QR = collections.namedtuple("QR", "Q, R")

if A.ndim == 3:
single_proc_qr = torch.vmap(torch.linalg.qr, in_dims=0, out_dims=0)
else:
Expand Down