Improvement in LASSO: Replace coordinate descent by FISTA #2056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for the PR! |
mtar
reviewed
Dec 3, 2025
Comment on lines
+60
to
+63
| lam: Optional[float] = 0.1, | ||
| max_iter: Optional[int] = 100, | ||
| tol: Optional[float] = 1e-6, | ||
| step_size: Optional[float] = None, |
Collaborator
There was a problem hiding this comment.
Are lam, max_iter, and tol allowed to be None? The docstring doesn't mention it.
Since python 3.10, you can also use float | None instead of Optional[float] if it confuses you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due Diligence
Description
Issue/s resolved: #
Changes proposed:
Type of change
Memory requirements
Performance
Does this change modify the behaviour of other functions? If so, which?
yes / no