Removed version restriction for scikit-learn in examples dependencies
#2086
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due Diligence
Description
See the discussion in #2084 for the problem and solution. Also, I refactored how the paths to the datasets are set up as
pkg_resourcesis deprecated and the old solution actually did not work with my editable installation of heat. I did make sure that this works with an installation directly from PyPI. That is to saypip install heat[h5py]; python examples/classification/demo_knn.pydoes work.Unrelated to the issue that this PR addresses: I see that the IO tests rely on being executed in a certain directory. As far as I can tell, this could be fixed by applying the same refactor from here, i.e. replacing
by
let me know if I should do this or if there is any reason not to.
Issue/s resolved:
#2084
Changes proposed:
Type of change
Bug fix