-
Notifications
You must be signed in to change notification settings - Fork 60
Adapted SVD API to match numpy API #2089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for the PR! |
|
Thank you for the PR! |
|
Thank you for the PR! |
Benchmarks results - Sponsored by perunFTPx86-AMD-Milan-Mi250 - CPU - N4 - RUNTIME
FTPx86-AMD-Milan-Mi250 - GPU - N4 - RUNTIME
Grafana Dashboard |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2089 +/- ##
==========================================
- Coverage 91.69% 91.68% -0.01%
==========================================
Files 89 89
Lines 13943 13946 +3
==========================================
+ Hits 12785 12787 +2
- Misses 1158 1159 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Due Diligence
Description
As detailed in #2054, the APIs of heat and numpy differ for svd in that heat returns$V$ and numpy returns $V^T$ in the decomposition $A = U S V^T$ . This PR changes the heat API for svd and related functions to match the numpy API.
Issue/s resolved: #2054
Changes proposed:
heat.core.linalg.svdType of change