Added support for complex values in QR #2105
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due Diligence
Description
As torch supports complex values in QR decomposition, only minimal changes are needed to make heat support it as well. Only the type check needs to be altered and the complex conjugate needs to be taken in a few places, that's it.
There is already a very similar PR open for this (#2040). However, it lacks testing. Here, I added tests. The diff is quite large because I split the test in subtests, but I actually changed very little there.
Issue/s resolved: #2039, #2040
Changes proposed:
Type of change