Skip to content

Conversation

@brownbaerchen
Copy link
Collaborator

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • NEW unit tests: MPS tested (1 MPI process, 1 GPU)
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

As torch supports complex values in QR decomposition, only minimal changes are needed to make heat support it as well. Only the type check needs to be altered and the complex conjugate needs to be taken in a few places, that's it.

There is already a very similar PR open for this (#2040). However, it lacks testing. Here, I added tests. The diff is quite large because I split the test in subtests, but I actually changed very little there.

Issue/s resolved: #2039, #2040

Changes proposed:

  • Allow complex values in QR

Type of change

  • New feature

@github-actions
Copy link
Contributor

Thank you for the PR!

@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.68%. Comparing base (95cb222) to head (75df28a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2105   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          89       89           
  Lines       13945    13945           
=======================================
  Hits        12786    12786           
  Misses       1159     1159           
Flag Coverage Δ
unit 91.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brownbaerchen brownbaerchen requested a review from mrfh92 January 15, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Make linalg.qr work with complex values

2 participants