Skip to content

Conversation

@krajsek
Copy link
Member

@krajsek krajsek commented Mar 18, 2021

Description

Issue/s resolved: #

Changes proposed:

Type of change

Due Diligence

  • All split configurations tested
  • Multiple dtypes tested in relevant functions
  • Documentation updated (if needed)
  • Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

yes / no

@ghost
Copy link

ghost commented May 12, 2022

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

❌ Patch coverage is 18.08511% with 77 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.72%. Comparing base (c282cb1) to head (02a7f82).
⚠️ Report is 658 commits behind head on main.

Files with missing lines Patch % Lines
heat/nn/batchnorm.py 18.82% 69 Missing ⚠️
heat/nn/__init__.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
- Coverage   92.24%   91.72%   -0.53%     
==========================================
  Files          84       85       +1     
  Lines       12460    12550      +90     
==========================================
+ Hits        11494    11511      +17     
- Misses        966     1039      +73     
Flag Coverage Δ
unit 91.72% <18.08%> (-0.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ClaudiaComito ClaudiaComito added this to the Repo Clean-Up milestone Jul 31, 2023
@mrfh92 mrfh92 mentioned this pull request Aug 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Thank you for the PR!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Thank you for the PR!

@ClaudiaComito ClaudiaComito removed this from the Repo Clean-Up milestone Feb 12, 2025
@github-actions github-actions bot added features testing Implementation of tests, or test-related issues nn labels Feb 13, 2025
@ClaudiaComito ClaudiaComito added the enhancement New feature or request label Feb 13, 2025
@github-actions
Copy link
Contributor

Thank you for the PR!

@JuanPedroGHM JuanPedroGHM added this to the Cold Storage milestone Apr 2, 2025
@github-project-automation github-project-automation bot moved this to Todo in Roadmap Apr 2, 2025
@github-actions
Copy link
Contributor

This pull request is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request features nn stale testing Implementation of tests, or test-related issues

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

6 participants