[generic] Replace reference to cachito-testing with hermetoproject #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's pretty much just a copy of artifacts.lock.yaml. The presence of this file is just historical and goes back to development time of the feature before it was decided that the default name is NOT to be 'generic_lockfile.yaml'. Signed-off-by: Erik Skultety <[email protected]>
When this test was created, an artificial release was created in the dedicated (back then) repository for the test only to reference it in the lockfile for test purposes. We consolidated all integration test cases to a single repository with the origin potentially removed in the future, so to make tests stable, we should point them to our own regular release tarballs. Signed-off-by: Erik Skultety <[email protected]>
slimreaper35
reviewed
Feb 7, 2025
| artifacts: | ||
| # this url will return 404 | ||
| - download_url: https://github.com/cachito-testing/cachi2-generic/archive/refs/tags/does-not-exist | ||
| - download_url: https://github.com/hermetoproject/cachi2/archive/refs/tags/does-not-exist |
Member
There was a problem hiding this comment.
Let's replace cachi2 with some arbitrary name too so we don't update the file again when replacing cachi2 references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.