ci: don't test on Uhyve anymore #857
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We can also (temporarily) run the uhyve tests on our custom runners. They seem to be stable there, right? |
Member
Author
|
Yes, but I would not like to use self-hosted runners here. If you are opposed to dropping Uhyve CI from this repo, I'd rather just move them to the start. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Uhyve is flaky on GitHub runners (hermit-os/uhyve#1150), we should either run it early to fail early (hermit-os/kernel#2003) or not run it at all.
This PR makes us not test on Uhyve at all. Since this is only the collection of example applications with no Uhyve-specific code, this might be the easiest. They will, of course, still be run comprehensively in the kernel CI.
I don't feel strongly about this, though. If you disagree, I'll just move the Uhyve run to the start.