fix(interrupts): activate interrupt masking on AArch64 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does that look good to you, @egrimley-arm? Thank you again for getting to the bottom of this. |
egrimley-arm
reviewed
Sep 6, 2023
Co-authored-by: Edmund Grimley Evans <[email protected]> Signed-off-by: Martin Kröning <[email protected]>
mkroening
force-pushed
the
aarch64-interrupts
branch
from
77773e0
to
9d4b616
Compare
mkroening
added a commit
to mkroening/libhermit-rs
that referenced
this pull request
Sep 6, 2023
This should fix deadlocks by updating hermit-sync to 0.1.4 (hermit-os/hermit-sync#16). Signed-off-by: Martin Kröning <[email protected]>
mkroening
added a commit
to mkroening/libhermit-rs
that referenced
this pull request
Sep 6, 2023
This should fix deadlocks by updating hermit-sync to 0.1.4 (hermit-os/hermit-sync#16). Signed-off-by: Martin Kröning <[email protected]>
stlankes
pushed a commit
to stlankes/kernel
that referenced
this pull request
Jul 22, 2024
This should fix deadlocks by updating hermit-sync to 0.1.4 (hermit-os/hermit-sync#16). Signed-off-by: Martin Kröning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by @egrimley-arm.
This will fix hermit-os/kernel#846 once it lands in the kernel.
The issue was that ones mask interrupts, not disable them.
Incidentally, the kernel got this right: hermit-os/kernel/src/arch/aarch64/kernel/interrupts.rs#L58-L95