-
Notifications
You must be signed in to change notification settings - Fork 23
Update of PCI scanning process in fdt #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
duanyu-yu
wants to merge
1
commit into
hermit-os:main
Choose a base branch
from
duanyu-yu:pci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
use pci_types::{ConfigRegionAccess, PciAddress}; | ||
use x86_64::instructions::port::Port; | ||
|
||
pub(crate) const PCI_MAX_BUS_NUMBER: u8 = 32; | ||
pub(crate) const PCI_MAX_DEVICE_NUMBER: u8 = 32; | ||
|
||
const PCI_CONFIG_ADDRESS_ENABLE: u32 = 1 << 31; | ||
|
||
const CONFIG_ADDRESS: Port<u32> = Port::new(0xcf8); | ||
const CONFIG_DATA: Port<u32> = Port::new(0xcfc); | ||
|
||
#[derive(Debug, Copy, Clone)] | ||
pub(crate) struct PciConfigRegion; | ||
|
||
impl PciConfigRegion { | ||
pub const fn new() -> Self { | ||
Self {} | ||
} | ||
} | ||
|
||
impl ConfigRegionAccess for PciConfigRegion { | ||
#[inline] | ||
fn function_exists(&self, _address: PciAddress) -> bool { | ||
true | ||
} | ||
|
||
#[inline] | ||
unsafe fn read(&self, pci_addr: PciAddress, register: u16) -> u32 { | ||
let mut config_address = CONFIG_ADDRESS; | ||
let mut config_data = CONFIG_DATA; | ||
|
||
let address = PCI_CONFIG_ADDRESS_ENABLE | ||
| (u32::from(pci_addr.bus()) << 16) | ||
| (u32::from(pci_addr.device()) << 11) | ||
| (u32::from(pci_addr.function()) << 8) | ||
| u32::from(register); | ||
|
||
unsafe { | ||
config_address.write(address); | ||
config_data.read() | ||
} | ||
} | ||
|
||
#[inline] | ||
unsafe fn write(&self, pci_addr: PciAddress, register: u16, value: u32) { | ||
let mut config_address = CONFIG_ADDRESS; | ||
let mut config_data = CONFIG_DATA; | ||
|
||
let address = PCI_CONFIG_ADDRESS_ENABLE | ||
| (u32::from(pci_addr.bus()) << 16) | ||
| (u32::from(pci_addr.device()) << 11) | ||
| (u32::from(pci_addr.function()) << 8) | ||
| u32::from(register); | ||
|
||
unsafe { | ||
config_address.write(address); | ||
config_data.write(value); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this TODO still relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the fdt output in the command line, the cells have to be 1 and 1 for now. But this is not standard. If we want a standard device tree, we have to configure the output tool first and change the cells respectively. So the question is do we need a standard device tree?