Timeout implementation #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First draft of generated satori cpp api Generate cpp grpcs for satori client Generalize git submodule urls wip satori grpc client and test Revert "Merge remote-tracking branch 'origin/private-build-rules' into satori-client-cpp" WIP build test Add dir tree to satori cmake generate cpp api First draft of generated satori cpp api Generate cpp grpcs for satori client Fix libhttpclient builds, rearrange build scripts for easier console builds Private build fixups protobuf + abseil PS5 wip All dependencies built wslay port added NDAed platforms build refactor Fix private builds factory methods Sync protobuf verion in public and private builds Remove unnecesasry compile definition libhttpclient build fixes Windows: align project and vcpkg deps on toolchain used. Fix wslay builds. Update to latest libHttpClient and provide build script for it. Also simplify bunch of build instructions switch to upstream libhttpclient Use aliases where possible for safety, cleanup libhttpclient build scripts GDK support for libhttpclient transport Use winhttp (via libhttpclient) on Windows Mac OSX Universal binary Update CHANGELOG.md Fix iOS builds Fix iphonesimulator builds Fix Linux builds Accurately list transports in README.md Generalize git submodule urls wip satori grpc client and test Revert "Merge remote-tracking branch 'origin/private-build-rules' into satori-client-cpp" WIP build test cmake minor fixes wip generate cpp api First draft of generated satori cpp api Generate cpp grpcs for satori client Generalize git submodule urls wip satori grpc client and test Revert "Merge remote-tracking branch 'origin/private-build-rules' into satori-client-cpp" WIP build test Add dir tree to satori cmake generate cpp api First draft of generated satori cpp api Generate cpp grpcs for satori client Fix libhttpclient builds, rearrange build scripts for easier console builds Private build fixups protobuf + abseil PS5 wip All dependencies built wslay port added NDAed platforms build refactor Fix private builds factory methods Sync protobuf verion in public and private builds Remove unnecesasry compile definition libhttpclient build fixes Windows: align project and vcpkg deps on toolchain used. Fix wslay builds. Update to latest libHttpClient and provide build script for it. Also simplify bunch of build instructions switch to upstream libhttpclient Use aliases where possible for safety, cleanup libhttpclient build scripts GDK support for libhttpclient transport Use winhttp (via libhttpclient) on Windows Mac OSX Universal binary Update CHANGELOG.md Fix iOS builds Fix iphonesimulator builds Fix Linux builds Accurately list transports in README.md Generalize git submodule urls wip satori grpc client and test Revert "Merge remote-tracking branch 'origin/private-build-rules' into satori-client-cpp" WIP build test cmake minor fixes wip wip setup cmake add
Add additional info to Satori Call Get Flags. More defensive json parsing.
|
I have changed base of this PR to more accurately reflect what is being changed |
redbaron
reviewed
Mar 17, 2025
| @@ -92,6 +92,17 @@ void NHttpClientCppRest::setBaseUri(const std::string& uri) | |||
| _client = std::make_unique<http_client>(http_client(FROM_STD_STR(uri))); | |||
| } | |||
|
|
|||
|
|
|||
|
|
|||
| void NHttpClientCppRest::setTimeout(int seconds) | |||
There was a problem hiding this comment.
- seconds might be too coarse
- use explicit std::chrono:: type for duration should be more ergonomic
There was a problem hiding this comment.
I'll double check, but if I'm not wrong, one of the three apis only accepted seconds. But you are right, if I use chrono::duration I can provide to each api the amount it accepts.
redbaron
reviewed
Mar 17, 2025
andresfelipemendez
approved these changes
Mar 19, 2025
…ded' into timeout-impl # Conflicts: # CMakeLists.txt
|
Client needs satori, so this branch now pulls in the full satori implementation too. I've not changed anything else from the original PR besides commit [555b2c4], but it's not substantial, only a rearrangement and what is necessary to get timeouts inside satori as well. |
redbaron
reviewed
Mar 20, 2025
impl/httpCppRest/CMakeLists.txt
Outdated
There was a problem hiding this comment.
cpprestsdk can probably go, AFAIK it is not used on any platform by default anymore
There was a problem hiding this comment.
Yeah, it's not used anywhere. I will remove it on another PR, though, I don't want to cram this one with even more changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.