Added sorting the list of opponents in the "Choose opponent": online users appear before offline users. #2145
+73
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fore offline users.
AlinLob
force-pushed
the
fix/sort-online-then-offline
branch
from
e31030f to
cfba364
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2145 +/- ##
==========================================
- Coverage 59.67% 59.08% -0.59%
==========================================
Files 254 256 +2
Lines 5285 5358 +73
==========================================
+ Hits 3154 3166 +12
- Misses 2131 2192 +61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vtm9
approved these changes
Apr 18, 2025
| @@ -35,29 +35,68 @@ const unchosenTask = { id: null }; | |||
| const OpponentSelect = memo(({ setOpponent, opponent }) => { | |||
| const dispatch = useDispatch(); | |||
| const currentUserId = useSelector(selectors.currentUserIdSelector); | |||
| const { presenceList } = useSelector(selectors.lobbyDataSelector); | |||
| console.log('presenceList:', presenceList); | |||
There was a problem hiding this comment.
let's remove this console.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1766