Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tagging of individual certificates/templates #54

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Tagging of individual certificates/templates #54

merged 2 commits into from
Jan 5, 2022

Conversation

MitanshiKshatriya
Copy link
Contributor

Closes #51
Added tags field to Template Schema and Certificate Schema

  1. Certificate Schema
title: {
		type: String,
		default: 'Certificate'
	},
	tags:[String], // Added tags field
	template: {
		type: String,
		required: true
	},
  1. Template Schema
....
tags:[String],
...

@paramsiddharth paramsiddharth added the enhancement New feature or request label Dec 20, 2021
paramsiddharth
paramsiddharth requested changes Dec 27, 2021
View reviewed changes
Copy link
Member

@paramsiddharth paramsiddharth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the suggested changes for a more consistent code style.

src/models/certificate.js Outdated
@@ -17,6 +17,7 @@ const certificateSchema = new Schema({
type: String,
default: 'Certificate'
},
tags:[String],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tags:[String],
tags: [String],

src/models/template.js Outdated
@@ -17,6 +17,7 @@ const templateSchema = new Schema({
type: String,
required: true
},
tags:[String],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tags:[String],
tags: [String],

@MitanshiKshatriya
Copy link
Contributor Author

I have made the changes please check.

paramsiddharth
paramsiddharth approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@paramsiddharth paramsiddharth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We'll proceed with further updates pertaining to the usage of tags.

@paramsiddharth paramsiddharth added the SWoC Under the Script Winter of Contributing. label Jan 5, 2022
@paramsiddharth paramsiddharth merged commit 6cc22ce into heyrema:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paramsiddharth paramsiddharth paramsiddharth approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request SWoC Under the Script Winter of Contributing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Labelling/Tagging of individual certificates/templates
2 participants
@MitanshiKshatriya @paramsiddharth