(not merge) chore: test react preamble script async #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
commented
Apr 30, 2025
Comment on lines
+31
to
+34
| head = head.replace( | ||
| '<script type="module">', | ||
| '<script type="module" async>', | ||
| ); |
Owner
Author
There was a problem hiding this comment.
Without async attribute, http://localhost:5173/test/loading/1 ("hydrate while streaming" example) fails by
chunk-3WLTBFGF.js:9 Uncaught Error: @vitejs/plugin-react can't detect preamble. Something is wrong.
at chunk-3WLTBFGF.js:9:11
hi-ogawa
commented
Apr 30, 2025
Comment on lines
+456
to
+460
| // import RefreshRuntime from "/@react-refresh"; | ||
| // RefreshRuntime.injectIntoGlobalHook(window); | ||
| // window.$RefreshReg$ = () => {}; | ||
| // window.$RefreshSig$ = () => (type) => type; | ||
| // window.__vite_plugin_react_preamble_installed__ = true; |
Owner
Author
There was a problem hiding this comment.
Practically speaking, we shouldn't have to worry about race condition since head script should finish first, so we don't need manual preamble injection.
hi-ogawa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(not the package directly but just replacing head script manually)