Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HHH-16097 Move all tests from documentation into hibernate-core #6051

Closed
wants to merge 1 commit into from
Closed

HHH-16097 Move all tests from documentation into hibernate-core #6051

wants to merge 1 commit into from

Conversation

dreab8
Copy link
Contributor

@dreab8 dreab8 commented Jan 30, 2023 •
edited
Loading

@sebersole
Copy link
Member

Sweet!

@mbladel mbladel force-pushed the HHH-16097 branch 4 times, most recently from 5755baa to 097e0a4 Compare March 9, 2023 15:08
@sebersole
Copy link
Member

Do you think this is ready to go @mbladel ? The sooner we integrate it, the less babysitting you have to do to keep it synced

@mbladel
Copy link
Contributor

mbladel commented Mar 20, 2023

Do you think this is ready to go @mbladel ? The sooner we integrate it, the less babysitting you have to do to keep it synced

@sebersole after the push I did today think it's ready, I was just waiting for #6229 to solve the last few test failures when adding the Jackson XML dependency. LMK if you want me to squash to a single commit before merging it.

@sebersole
Copy link
Member

LMK if you want me to squash to a single commit before merging it

👍

@sebersole
Copy link
Member

Pulled this locally to rebase and resolve conflicts. I'll integrate upstream after.

@sebersole
Copy link
Member

Integrated upstream. Pushed to main already; running tests locally on 6.2 from cherry-pick

@sebersole sebersole closed this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beikov beikov beikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dreab8 @sebersole @mbladel @beikov