-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-16648 Documentation for implementing custom JPQL/HQL functions #6605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern
› This message was automatically generated. |
9db8b06
to
d67a998
Compare
I would appreciate feedback on the status of this pull request. Is the code being reviewed or rejected? |
I'm sorry this takes so long. Your PR is very much appreciated and we will look into it. We are currently busy with other things. I added your PR to my todo list, so be assured that I will review it eventually. |
Thank you very much! |
Please let me know what needs to be fixed or added in my code for you to accept my pull request. |
c1ae9de
to
680037d
Compare
680037d
to
adc1885
Compare
@Override | ||
public void render( | ||
SqlAppender sqlAppender, | ||
List<? extends SqlAstNode> sqlAstArguments, | ||
Predicate filter, | ||
SqlAstTranslator<?> translator) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really not sure how much of an open invitation we really want to be giving to users to start depending on some of these SPIs in their application programs.
Yes, it's true that org.hibernate.sql.ast
and org.hibernate.sql.ast.tree
are technically SPIs, but they're both marked @Incubating
for the very good reason that:
- they're an extremely broad SPI surface, and
- not really stabilized in any meaningful sense.
So I would leave this undocumented for now.
I propose a technology for creating custom JPQL/HQL functions (code and documentation).
https://hibernate.atlassian.net/browse/HHH-16648