Skip to content

Conversation

FelixDes
Copy link

@FelixDes FelixDes commented May 20, 2023

I propose a technology for creating custom JPQL/HQL functions (code and documentation).

https://hibernate.atlassian.net/browse/HHH-16648

@hibernate-github-bot
Copy link

hibernate-github-bot bot commented May 20, 2023

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [adc1885]
❌ The pull request description must contain the license agreement text.
    ↳ The description of this pull request must contain the following license agreement text:

----------------------
By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license](https://www.apache.org/licenses/LICENSE-2.0.txt)
and can be relicensed under the terms of the [LGPL v2.1 license](https://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt) in the future at the maintainers' discretion.
For more information on licensing, please check [here](https://github.com/hibernate/hibernate-orm/blob/main/CONTRIBUTING.md#legal).

----------------------

› This message was automatically generated.

@FelixDes FelixDes closed this May 20, 2023
@FelixDes FelixDes reopened this May 20, 2023
@FelixDes FelixDes force-pushed the HHH-16648_custom_finctions_doc branch 2 times, most recently from 9db8b06 to d67a998 Compare May 20, 2023 12:26
@FelixDes FelixDes changed the title HHH-16648 HHH-16648 Documentation for implementing custom JPQL/HQL functions May 20, 2023
@FelixDes
Copy link
Author

I would appreciate feedback on the status of this pull request. Is the code being reviewed or rejected?

@beikov
Copy link
Member

beikov commented May 23, 2023

I'm sorry this takes so long. Your PR is very much appreciated and we will look into it. We are currently busy with other things. I added your PR to my todo list, so be assured that I will review it eventually.

@FelixDes
Copy link
Author

Thank you very much!

@FelixDes
Copy link
Author

FelixDes commented Jun 6, 2023

Please let me know what needs to be fixed or added in my code for you to accept my pull request.

@yrodiere yrodiere force-pushed the HHH-16648_custom_finctions_doc branch from c1ae9de to 680037d Compare October 3, 2025 17:40
@yrodiere yrodiere force-pushed the HHH-16648_custom_finctions_doc branch from 680037d to adc1885 Compare October 3, 2025 17:43
@yrodiere yrodiere self-assigned this Oct 3, 2025
@yrodiere yrodiere self-requested a review October 3, 2025 17:43
Comment on lines +73 to +78
@Override
public void render(
SqlAppender sqlAppender,
List<? extends SqlAstNode> sqlAstArguments,
Predicate filter,
SqlAstTranslator<?> translator) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really not sure how much of an open invitation we really want to be giving to users to start depending on some of these SPIs in their application programs.

Yes, it's true that org.hibernate.sql.ast and org.hibernate.sql.ast.tree are technically SPIs, but they're both marked @Incubating for the very good reason that:

  1. they're an extremely broad SPI surface, and
  2. not really stabilized in any meaningful sense.

So I would leave this undocumented for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants