Support @IdGeneratorType #2407
Closed
Support @IdGeneratorType #2407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -38,4 +41,18 @@ | |||
| default CompletionStage<Id> generate(ReactiveConnectionSupplier session, Object owner, Object currentValue, EventType eventType) { | |||
| return generate( session, owner ); | |||
| } | |||
|
|
|||
| @Override | |||
| default Id generate( | |||
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| } | ||
|
|
||
| @Override | ||
| default Object generate(SharedSessionContractImplementor session, Object object){ |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
|
@dreab8 Do you need this PR? It was a rebased of your original PR with a couple of changes. But I suspect It's not needed anymore and I would prefer to close it to clean up a bit. |
|
@DavideD I don't really need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1906
Supersedes #2380