-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General doc page fixes [moved from highlight/highlight.io#449] #4736
Conversation
a more detailed commit list is at highlight/highlight.io#449
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, a few comments:
- stacking on the guide pages is working for mobil, but now its not side-by-side on desktop?
- mobile dropdown + heading edits:
https://www.loom.com/share/09f4f1bc01d7438b99714c0130ed0dcd - thoughts on headings:
https://www.loom.com/share/a317db40cd8f4534b12aa18bb1419ac8
preview should be working now - https://highlight-landing-git-general-doc-fixes-highlight-run.vercel.app/docs/getting-started/client-sdk/angular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix session replay, then looks good!
things to follow up on:
- jankiness on links
- smaller headers don't work
Summary
Original PR, with a more detailed commit history highlight/highlight.io#449
Make any header linkable(Ran into issues with this, not sure how to fix it)