Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General doc page fixes [moved from highlight/highlight.io#449] #4736

Merged
merged 10 commits into from
Apr 8, 2023

Conversation

Crawron
Copy link
Contributor

@Crawron Crawron commented Mar 28, 2023

Summary

Original PR, with a more detailed commit history highlight/highlight.io#449


  • Subheading in doc pages should be linked
  • Heading ids in doc pages generate inconsistently
  • Scrolling from right sidebar is “misaligned”


  • Automatically close menu on docs page in mobile
  • Remove duplicated forward slashes in links

@vercel
Copy link

vercel bot commented Mar 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
highlight-landing ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 29, 2023 at 4:52AM (UTC)

Copy link
Collaborator

@jay-khatri jay-khatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, a few comments:

@Vadman97
Copy link
Member

Copy link
Collaborator

@jay-khatri jay-khatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix session replay, then looks good!
things to follow up on:

  • jankiness on links
  • smaller headers don't work

@Crawron Crawron merged commit b3ebd67 into main Apr 8, 2023
@Crawron Crawron deleted the general-doc-fixes branch April 8, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants