Skip to content

Conversation

demetrius-mp
Copy link
Contributor

adds suport for inline prop
closes #5

Copy link
Owner

@himynameisdave himynameisdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! This appears to include your changes from #29, so I'll go review that one first.

@himynameisdave himynameisdave added the enhancement New feature or request label Sep 16, 2022
@demetrius-mp
Copy link
Contributor Author

i forgot to add the new props on the readme section

@himynameisdave
Copy link
Owner

himynameisdave commented Sep 16, 2022

i forgot to add the new props on the readme section

@demetrius-mp Good catch, do you mind adding that here, as well as in #29 ?

@demetrius-mp
Copy link
Contributor Author

ok, ill add them

@demetrius-mp
Copy link
Contributor Author

sorry, i definetly messed up something when doing the branches thing. im new to open source 😅

i think that if you close #29 and merge only this PR, it will be ok, since this PR has the commits from #29.

this PR has

  • inline prop with its tests, and also declared on the readme
  • gap prop with its tests, the adjustments suggested here, and also declared on the readme

@himynameisdave
Copy link
Owner

i think that if you close #29 and merge only this PR,

I'd rather have each of these props included as separate commits (makes it easier to revert if there are any issues, plus I it's a nicer commit history to keep things separated). Please address the final comments in #29 and then we can take a look at this PR :)

@demetrius-mp
Copy link
Contributor Author

ok!

@himynameisdave
Copy link
Owner

@demetrius-mp same comment as here, sorry! #29 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support inline-flex

2 participants