fix: issue 407, add IntersectionObserver mock to Dom #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsdom does not implement IntersectionObserver so we need to mock it. This is similar in scope to histoire-dev@2d16838
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
|
✅ Deploy Preview for histoire-examples-svelte3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-examples-vue3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-controls ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for histoire-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Exac
reviewed
Feb 26, 2025
| rootMargin: string | ||
| thresholds: number[] | ||
| disconnect(): void { /* noop */ } | ||
| observe(_target: Element): void { /* noop */ } |
There was a problem hiding this comment.
This should be:
observe = (_target: Element): void => {};Of you will get errors like:
console.error
ERROR TypeError: intersectionObserver.observe is not a function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add mock ResizeObserver to DOM after jsdom initialisation to fix #407. jsdom does not implement IntersectionObserver so we mock it.
Additional context
I stumbled onto this issue when using nk-o/jarallax in a component, which uses IntersectionObserver and breaks histoire stories. There is an open issue on jsdom here: jsdom/jsdom#2032 but looks like a won't fix due to the project's scope. This is a quick noop fix similar to (and indeed based on)
2d16838 / #664
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).