Open
Conversation
792eaaf to
74ecad7
Compare
b62063a to
53f9e51
Compare
53f9e51 to
e36c341
Compare
e36c341 to
933c9c7
Compare
566edf0 to
919e805
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses a Store for analysis
Loads Analysis with a OnceResource and avoids the suspend barrierUse a local resource, no reason no load this in the server. Do a simple refactor for readability but the suspend barrier when providing the context makes sense and should be required (ion is always right :D)Ensures uhp strings and the move param in the query can be used in tandem
Only move in analysis history if arrow is pressed without any modifiers. (Fixes Don't override browser shortcuts in analysis mode #691)
Created the full_path field in Analysis tree
This maintains a full path from root to leaf of a "best guess" for the possible variation the user wants to traverse. Then instead of redrawing everything, jump forward or backward a few moves. It has the following advantages:
Requires #703
Hopefully fixes #508 and #696