Skip to content

Analysis improve#705

Open
PenguinWithATie wants to merge 4 commits intomainfrom
analysis_improve
Open

Analysis improve#705
PenguinWithATie wants to merge 4 commits intomainfrom
analysis_improve

Conversation

@PenguinWithATie
Copy link
Copy Markdown
Collaborator

@PenguinWithATie PenguinWithATie commented Mar 14, 2026

  • Uses a Store for analysis

  • Loads Analysis with a OnceResource and avoids the suspend barrier Use a local resource, no reason no load this in the server. Do a simple refactor for readability but the suspend barrier when providing the context makes sense and should be required (ion is always right :D)

  • Ensures uhp strings and the move param in the query can be used in tandem

  • Only move in analysis history if arrow is pressed without any modifiers. (Fixes Don't override browser shortcuts in analysis mode #691)

Created the full_path field in Analysis tree

This maintains a full path from root to leaf of a "best guess" for the possible variation the user wants to traverse. Then instead of redrawing everything, jump forward or backward a few moves. It has the following advantages:

  • The arrows work fast since a single step is very quick to do.
  • Jumping to "near" points in the tree is quick
  • In the worst case we need to recompute the full path, which wont happen if the tree isnt to dense. And even then, recomputing the full path for a 150~200 nodes is not that bad.
  • Its not required to serialized and can be reconstructed from the rest of the data

Requires #703

Hopefully fixes #508 and #696

@PenguinWithATie PenguinWithATie marked this pull request as draft March 14, 2026 07:43
@PenguinWithATie PenguinWithATie linked an issue Mar 14, 2026 that may be closed by this pull request
@PenguinWithATie PenguinWithATie force-pushed the analysis_improve branch 3 times, most recently from 792eaaf to 74ecad7 Compare March 14, 2026 17:12
@PenguinWithATie PenguinWithATie force-pushed the analysis_improve branch 6 times, most recently from b62063a to 53f9e51 Compare March 29, 2026 04:49
@PenguinWithATie PenguinWithATie marked this pull request as ready for review March 29, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant