Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constraint solving for function overloading #213

Draft
wants to merge 40 commits into
base: mlscript
Choose a base branch
from
Draft

Constraint solving for function overloading #213

wants to merge 40 commits into from

Conversation

auht
Copy link

@auht auht commented Mar 4, 2024

No description provided.

@LPTK LPTK mentioned this pull request Mar 11, 2024
Closed
@LPTK LPTK changed the base branch from new-definition-typing to mlscript March 11, 2024 08:21
@LPTK
Copy link
Contributor

LPTK commented May 17, 2024

Do you intend to fix the bug and merge this?

LPTK
LPTK reviewed May 20, 2024
View reviewed changes
shared/src/test/diff/fcp/Overloads.mls
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the TODOs and FIXMEs here.

@LPTK
Copy link
Contributor

LPTK commented Jun 17, 2024

Can you plz fix the conflicts and get this PR ready?

@LPTK
Copy link
Contributor

LPTK commented Aug 26, 2024 •
edited
Loading

  • TODO: Guard this feature behind a flag.

LPTK
LPTK reviewed Sep 19, 2024
View reviewed changes
shared/src/test/diff/fcp/Overloads.mls Outdated Show resolved Hide resolved
shared/src/test/diff/nu/HeungTung.mls Outdated
fun s: Str -> Str & AA -> AA
//│ fun s: Str -> Str & AA -> AA

// FIXME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handle this: why isn't an ambiguity raised? Add the check to the top-level foralls as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LPTK LPTK LPTK left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@auht @LPTK