Skip to content

imp: Add ' as possible digit separator - #1890

Closed
ThreeFx wants to merge 1 commit into
hledgerorg:masterfrom
ThreeFx:master
Closed

imp: Add ' as possible digit separator#1890
ThreeFx wants to merge 1 commit into
hledgerorg:masterfrom
ThreeFx:master

Conversation

@ThreeFx

@ThreeFx ThreeFx commented Jul 18, 2022

Copy link
Copy Markdown

It is used for Swiss Francs: CHF 1'000

@ghost

ghost commented Jul 18, 2022

Copy link
Copy Markdown

Review on Crocodile

@Xitian9

Xitian9 commented Jul 18, 2022

Copy link
Copy Markdown
Collaborator

This requires careful consideration to make sure we don't mess up parsing in other cases. See related discussion at #1489, #273.

@simonmichael

simonmichael commented Jul 31, 2022

Copy link
Copy Markdown
Member

@ThreeFx, thanks for this. Some ideas to move it forward:

  • update the docs in hledger.m4.md > Decimal marks, digit group marks
  • add a test or two, I think numbers.test would be the right place
  • at least manually sanity-check that it works as expected in the commodity directive and --commodity option

@simonmichael simonmichael added A-WISH Some kind of improvement request or proposal. cli Command line parsing, options, arguments and suchlike. journal The journal file format, and its features. labels Jul 31, 2022
@ThreeFx
ThreeFx force-pushed the master branch 3 times, most recently from b931f3f to 05f3c69 Compare January 19, 2023 19:52
@ThreeFx
imp: Add ' as possible digit separator
eb414aa 
It is used for Swiss Francs: CHF 1'000.
@simonmichael simonmichael added needs-testing To unblock: needs more developer testing or general usage needs-docs To unblock: needs corresponding documentation or doc updates needs-tests To unblock: needs more automated tests or test updates needs-rebase To unblock: needs to be rebased against latest master branch labels Apr 5, 2023
@simonmichael

simonmichael commented May 17, 2025

Copy link
Copy Markdown
Member

Hi @ThreeFx, are you still interested in this hledger PR: Add ' as possible digit separator ?

@simonmichael

simonmichael commented May 27, 2025

Copy link
Copy Markdown
Member

Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-WISH Some kind of improvement request or proposal. cli Command line parsing, options, arguments and suchlike. journal The journal file format, and its features. needs-docs To unblock: needs corresponding documentation or doc updates needs-rebase To unblock: needs to be rebased against latest master branch needs-testing To unblock: needs more developer testing or general usage needs-tests To unblock: needs more automated tests or test updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ThreeFx @Xitian9 @simonmichael