feat(workers): Adds publisher and author og:meta tags to Bookmark #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedBassem
requested changes
Mar 12, 2025
Comment on lines
+153
to
+152
| author: text("author"), | ||
| publisher: text("publisher"), |
There was a problem hiding this comment.
The migration file seems to have not been refreshed.
There was a problem hiding this comment.
I think I got it this time.
ebenoist
force-pushed
the
erik/author-publisher
branch
from
4066efe to
3e75a50
Compare
ebenoist
force-pushed
the
erik/author-publisher
branch
from
3e75a50 to
f703188
Compare
erik-nilcoast
commented
Mar 12, 2025
| ALTER TABLE `bookmarkLinks` ADD `publisher` text;--> statement-breakpoint | ||
| ALTER TABLE `bookmarkLinks` ADD `datePublished` text;--> statement-breakpoint | ||
| ALTER TABLE `bookmarkLinks` ADD `dateModified` text;--> statement-breakpoint | ||
| ALTER TABLE `bookmarks` ADD `modifiedAt` integer; |
There was a problem hiding this comment.
This snuck in but isn't related to my changes. Maybe some local state or a bad migration?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.