-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support SharedPreferencesWithCache and SharedPreferencesAsync. #76
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #76 +/- ##
==========================================
- Coverage 98.02% 92.85% -5.17%
==========================================
Files 9 11 +2
Lines 152 252 +100
==========================================
+ Hits 149 234 +85
- Misses 3 18 +15 ☔ View full report in Codecov by Sentry. |
@hoc081098 any progress on this one? |
It is basically done, I will recheck it again and publish a release 🙏 |
Just wanted to check in on this again - would love to see this merged! |
The work is quite busy 😂, so I will check it again this weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces support for SharedPreferencesWithCache and SharedPreferencesAsync by updating dependency versions and project configurations.
- Update environment SDK and Flutter version requirements, along with dependencies in pubspec files.
- Upgrade Java version and streamline the Flutter version matrix in workflow files.
- Upgrade tooling versions, including Codecov and flutter_lints, to support the new features.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
File | Description |
---|---|
example/pubspec.yaml | Updates environment and dependency versions to support new features. |
.github/workflows/build-example.yml | Upgrades Java version and reduces matrix testing to Flutter 3.22.0. |
.github/workflows/tests.yml | Upgrades Codecov action and updates test matrix for Flutter 3.22.0. |
pubspec.yaml | Updates environment and dependency versions for broader compatibility. |
Comments suppressed due to low confidence (2)
.github/workflows/build-example.yml:67
- Reducing the test matrix to a single Flutter version may limit coverage; consider retaining additional versions if broader compatibility testing is desired.
version: [ '3.22.0' ]
.github/workflows/tests.yml:53
- Limiting the test matrix to Flutter 3.22.0 might leave regressions in earlier supported versions undetected; evaluate if testing multiple versions is necessary.
version: [ '3.22.0' ]
issue #75
This pull request includes several updates to the build configurations, dependency versions, and code refactoring for better performance and compatibility. The most important changes are grouped into themes as follows:
Build Configuration Updates:
.github/workflows/build-example.yml
to align with newer Java standards. [1] [2]example/android/gradle/wrapper/gradle-wrapper.properties
.example/android/app/build.gradle
to compileSdkVersion 34, minSdkVersion 24, and targetSdkVersion 34 for better compatibility with newer Android versions. [1] [2]Dependency and Version Updates:
example/pubspec.yaml
, including Flutter SDK to 3.22.0 and various other dependencies for improved performance and compatibility..github/workflows/tests.yml
to v4 and added theCODECOV_TOKEN
environment variable for better integration.Code Refactoring and Enhancements:
example/android/app/build.gradle
to streamline the build process and improve code quality.example/lib/home.dart
andexample/lib/dialog.dart
for better clarity and consistency. [1] [2]void main()
inexample/lib/main.dart
to useRxSharedPreferences.async
for asynchronous operations.New Implementations:
SharedPreferencesAsyncAdapter
andSharedPreferencesWithCacheAdapter
inlib/src/impl/async/
to support asynchronous operations and caching mechanisms. [1] [2]File and Structure Changes:
lib/src/impl/shared_preferences_adapter.dart
tolib/src/impl/legacy/shared_preferences_adapter.dart
and updated imports to reflect the new structure.