Fix 'autoack - value beneath null values' test flaking #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the test could fail when an ack triggered during checks for `sync()`. The ack would complete before the final promise resolved in `sync()` causing the length stored before the 1s timeout to be the final resolved length that is supposed to be different. This is just a timing issue where the 'before' is remembered after the 'after' is complete. 100ms didn't flake after ~195 runs mining the test.
Test still broke w/ the longer `ackInterval` when the test took even longer. The length can be stored immediately after appending to prevent timing issues.
|
Hmm. Just got it to flake still when running all tests together. The test seems to have taken longer than normal (3266ms). |
lejeunerenard
changed the title
ackInterval in 'autoack - value beneath null values' test
|
its bugging out cause now it might ack during the sync |
|
so we find a way, for testing, to disable that or make the condition simpler at least |
|
might be easier to simply assert that the view gets indexed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the test could fail when an ack triggered during checks for
sync(). The ack would complete before the final promise resolved insync()causing the length stored before the 1s timeout to be the final resolved length that is supposed to be different.This is just a timing issue where the 'before' is remembered after the 'after' is complete.
100ms didn't flake after ~195 runs mining the test. Previously the test flaked after ~20-30 runs. Increasing theackIntervaldoesn't significantly increase the test time as it is less than the 1s timeout waiting for the ack.Fix has been changed to saving the length before calling
sync().