Dump files to the stdout if filename is specified. #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafapaezbas
reviewed
Jan 24, 2025
| let { dir } = cmd.args | ||
| if (!link) throw ERR_INVALID_INPUT('<link> must be specified.') | ||
| if (!dir) throw ERR_INVALID_INPUT('<dir> must be specified.') | ||
| dir = dir === '-' ? '-' : (isAbsolute(dir) ? dir : resolve('.', dir)) | ||
| if (dir === '-') { |
There was a problem hiding this comment.
dir === '-' || getFileNameFromPearUrl
rafapaezbas
reviewed
Jan 24, 2025
Comment on lines
+26
to
+27
| const pathParts = path.split('/') | ||
| return pathParts[pathParts.length - 1] |
There was a problem hiding this comment.
If the return value is not used you could return a boolean instead
rafapaezbas
reviewed
Jan 24, 2025
| @@ -118,8 +118,8 @@ module.exports = async (ipc, argv = Bare.argv.slice(1)) => { | |||
| const dump = command( | |||
| 'dump', | |||
| summary('Synchronize files from key to dir'), | |||
| arg('<link>', 'Pear link to dump from, supports pathname'), | |||
| arg('<dir>', 'Directory path to dump to, may be - for stdout'), | |||
| arg('<link>', 'Pear link to dump from, supports pathname. Pathname will always dump the the stdout'), | |||
rafapaezbas
reviewed
Jan 24, 2025
| @@ -18,12 +18,36 @@ const output = outputter('stage', { | |||
| } | |||
| }) | |||
|
|
|||
| function getFileNameFromPearUrl(url) { | |||
| if (url.startsWith('pear://')) { | |||
| const urlParts = url.slice(7).split('/') | |||
There was a problem hiding this comment.
use https://github.com/holepunchto/pear-link instead of manual parsing
|
please run npx standard --fix to reformat the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If file name is specified they will be dumped to the stdout, for example:
"pear:///path/to/file ." will dump to the stdout