Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pear-next] pear data apps fix duplicates #658

Open
wants to merge 88 commits into
base: pear-next
Choose a base branch
from

Conversation

AndreiRegiani
Copy link
Contributor

  • Bug fix: normalize bundle links to avoid duplicates (trim #segments and paths, keep origin)

Dependency: holepunchto/pear-link#7

pear run pear://keet/foo#bar
# inserts to db `pear://keet`

Sub-tasks:

  • Bug fix: handle null error on pear data apps {link not found}
  • Cosmetic: renamed stdout labels: appStorage -> storage & encryptionKey -> encryption

  • Bug fix: pear data apps {link} now supports different lookups:
# inputs

/Users/user/holepunch/pear-desktop
/Users/user/holepunch/pear-desktop/
file:///Users/user/holepunch/pear-desktop
file:///Users/user/holepunch/pear-desktop/

# same output

file:///Users/user/holepunch/pear-desktop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants