Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dbx dropdown in homepage #474

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

NQPhuc
Copy link
Contributor

@NQPhuc NQPhuc commented Nov 7, 2023

Summary

  • Add Holistics to dbx dropdown
  • Update name for other dbx product in dropdown

dropdown-dbml

Issue

(issue link here)

Lasting Changes (Technical)

(please list down: code changes/things that have wide-effect; new libraries/functions added that can be used by others; examples below)

  • (Added class EmailValidator to validate email address' validity)
  • (Added Tenant#is_trial? check)

Checklist

Please check directly on the box once each of these are done

  • Documentation (if necessary)
  • Tests (integration test/unit test)
  • Integration Tests Passed
  • Code Review

@NQPhuc NQPhuc requested a review from TeaNguyen November 7, 2023 10:40
Copy link
Collaborator

@TeaNguyen TeaNguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NQPhuc NQPhuc merged commit 4f78c69 into master Nov 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants