Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add secrets to nomad-server repo #14

Merged
merged 5 commits into from
Feb 5, 2025
Merged

feat: add secrets to nomad-server repo #14

merged 5 commits into from
Feb 5, 2025
+88 −10

Conversation

cdunster
Copy link
Contributor

@cdunster cdunster commented Feb 3, 2025

No description provided.

@cdunster cdunster requested a review from ThetaSinner February 3, 2025 09:45
@cdunster cdunster self-assigned this Feb 3, 2025
cdunster
cdunster commented Feb 3, 2025
View reviewed changes
main.go Outdated Show resolved Hide resolved
@cdunster cdunster mentioned this pull request Feb 3, 2025
Merged
cdunster
cdunster commented Feb 3, 2025
View reviewed changes
main.go Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025 •
edited
Loading

🍹 preview on holochain/holochain/github

Pulumi report 
  Previewing update (holochain/github)

View Live: https://app.pulumi.com/holochain/holochain/github/previews/f35e27de-4db5-4525-80d1-9f34b8d6b397

pulumi:pulumi:Stack: (same)
  [urn=urn:pulumi:github::holochain::pulumi:pulumi:Stack::holochain-github]
  + github:index/actionsSecret:ActionsSecret: (create)
      [urn=urn:pulumi:github::holochain::github:index/actionsSecret:ActionsSecret::hc-github-config-github-token]
      [provider=urn:pulumi:github::holochain::pulumi:providers:github::default_6_3_2::f35b83ba-4dee-49e0-89a8-c4c3899a3d02]
      plaintextValue: [secret]
      repository    : "hc-github-config"
      secretName    : "HRA2_GITHUB_TOKEN"
  + github:index/actionsSecret:ActionsSecret: (create)
      [urn=urn:pulumi:github::holochain::github:index/actionsSecret:ActionsSecret::hc-github-config-pulumi-access-token]
      [provider=urn:pulumi:github::holochain::pulumi:providers:github::default_6_3_2::f35b83ba-4dee-49e0-89a8-c4c3899a3d02]
      plaintextValue: [secret]
      repository    : "hc-github-config"
      secretName    : "HRA2_PULUMI_ACCESS_TOKEN"
  + github:index/actionsSecret:ActionsSecret: (create)
      [urn=urn:pulumi:github::holochain::github:index/actionsSecret:ActionsSecret::nomad-server-pulumi-access-token]
      [provider=urn:pulumi:github::holochain::pulumi:providers:github::default_6_3_2::f35b83ba-4dee-49e0-89a8-c4c3899a3d02]
      plaintextValue: [secret]
      repository    : "nomad-server"
      secretName    : "HRA2_PULUMI_ACCESS_TOKEN"
  + github:index/actionsSecret:ActionsSecret: (create)
      [urn=urn:pulumi:github::holochain::github:index/actionsSecret:ActionsSecret::nomad-server-github-token]
      [provider=urn:pulumi:github::holochain::pulumi:providers:github::default_6_3_2::f35b83ba-4dee-49e0-89a8-c4c3899a3d02]
      plaintextValue: [secret]
      repository    : "nomad-server"
      secretName    : "HRA2_GITHUB_TOKEN"
  + github:index/actionsSecret:ActionsSecret: (create)
      [urn=urn:pulumi:github::holochain::github:index/actionsSecret:ActionsSecret::kitsune2-github-token]
      [provider=urn:pulumi:github::holochain::pulumi:providers:github::default_6_3_2::f35b83ba-4dee-49e0-89a8-c4c3899a3d02]
      plaintextValue: [secret]
      repository    : "kitsune2"
      secretName    : "HRA2_GITHUB_TOKEN"
  - github:index/actionsSecret:ActionsSecret: (delete)
      [id=kitsune2:AUTOMATION_USER_TOKEN]
      [urn=urn:pulumi:github::holochain::github:index/actionsSecret:ActionsSecret::kitsune2-automation-user-token]
      [provider=urn:pulumi:github::holochain::pulumi:providers:github::default_6_3_2::f35b83ba-4dee-49e0-89a8-c4c3899a3d02]
      plaintextValue: [secret]
      repository    : "kitsune2"
      secretName    : "AUTOMATION_USER_TOKEN"
Resources:
  + 5 to create
  - 1 to delete
  6 changes. 111 unchanged

@cdunster cdunster requested a review from a team February 3, 2025 14:53
ThetaSinner
ThetaSinner previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks great! Thanks for jumping in and making improvements on this project :)

jost-s
jost-s previously approved these changes Feb 3, 2025
View reviewed changes
Copy link

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other repo should need admin access to any repo.

@cdunster cdunster dismissed stale reviews from jost-s and ThetaSinner via 3bab81e February 4, 2025 11:45
@cdunster cdunster force-pushed the add-secrets-to-nomad-server-repo branch from 3bab81e to 039781a Compare February 4, 2025 11:52
cdunster
cdunster commented Feb 4, 2025
View reviewed changes
main.go Show resolved Hide resolved
c12i
c12i reviewed Feb 4, 2025
View reviewed changes
main.go Show resolved Hide resolved
main.go Show resolved Hide resolved
jost-s
jost-s previously approved these changes Feb 4, 2025
View reviewed changes
ThetaSinner
ThetaSinner reviewed Feb 4, 2025
View reviewed changes
main.go Outdated Show resolved Hide resolved
@cdunster cdunster force-pushed the add-secrets-to-nomad-server-repo branch from 039781a to 846ad4a Compare February 5, 2025 09:14
@cdunster cdunster requested review from c12i and ThetaSinner February 5, 2025 13:24
@cdunster cdunster requested a review from jost-s February 5, 2025 13:24
@cdunster cdunster merged commit c71adf9 into main Feb 5, 2025
2 checks passed
@cdunster cdunster deleted the add-secrets-to-nomad-server-repo branch February 5, 2025 13:34
@cdunster cdunster mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThetaSinner ThetaSinner ThetaSinner approved these changes

@c12i c12i c12i approved these changes

@jost-s jost-s Awaiting requested review from jost-s

Assignees

@cdunster cdunster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cdunster @ThetaSinner @jost-s @c12i