Skip to content

Add versions and apps#11

Merged
ThetaSinner merged 10 commits intomainfrom
versions-and-apps
Jun 5, 2024
Merged

Add versions and apps#11
ThetaSinner merged 10 commits intomainfrom
versions-and-apps

Conversation

@ThetaSinner
Copy link
Member

No description provided.

holochain.program = "${holochain}/bin/holochain";
lair-keystore.program = "${lair-keystore}/bin/lair-keystore";
hc-launch.program = "${hc-launch}/bin/hc-launch";
hc-scaffold.program = "${hc-scaffold}/bin/hc-scaffold";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means we can scaffold without needing to download binaries for everything that's in the Holonix shell. As long as it's cached of course! This will reduce the download size to get started.

craneLib.buildPackage {
pname = "lair-keystore";
src = craneLib.cleanCargoSource inputs.hc-scaffold;
pname = "hc-scaffold";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You saw nothing, move along :)

in
craneLib.buildPackage {
pname = "holochain";
version = "workspace";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd done this in the old Holonix for some unknown reason, I don't think it's something we want to keep until a reason appears

@ThetaSinner ThetaSinner requested a review from jost-s June 4, 2024 18:16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this even here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume a backup or something at some point? Not sure, but not being read by anything and I don't think it has anything that isn't in the pipeline that we are using


- run: result/bin/${{ matrix.package }} --version

- name: Run nix app
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can replace the previous command.


# outputs that this flake should produce
outputs = inputs @ { self, nixpkgs, flake-parts, rust-overlay, crane, holochain-src, lair-keystore-src, hc-launch-src, ... }:
outputs = inputs @ { self, nixpkgs, flake-parts, rust-overlay, crane, ... }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ThetaSinner and others added 3 commits June 5, 2024 13:43
Co-authored-by: Jost Schulte <jost.schulte@protonmail.com>
os: [ubuntu-latest, macos-latest, macos-13]
package: [holochain, lair-keystore, hc-launch, hc-scaffold]
packages:
- [holochain, hc, hc-run-local-services, hc-sandbox, hcterm]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grouped because they all build the same derivation - so even with a cache it will de-duplicate work to run these on the same machine

Co-authored-by: Jost Schulte <jost.schulte@protonmail.com>
uses: cachix/install-nix-action@v27
with:
install_url: https://releases.nixos.org/nix/nix-2.18.0/install
install_url: https://releases.nixos.org/nix/nix-2.22.1/install
Copy link
Contributor

@jost-s jost-s Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versioning of the Nix package manager is confusing. On nixos.org the recommended version is 2.22.1, but in nixpkgs' nix the stable version is still 2.18.2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's quite unhelpful that. It is as you say, but we should be getting a new version of nixpkgs soon (a 2024 version) that will have the newer Nix in.

I think as an end-user who is not running on NixOS, the latest Nix is fair game to use

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's go with the one on the nix website.

@ThetaSinner ThetaSinner merged commit 16a5629 into main Jun 5, 2024
@ThetaSinner ThetaSinner deleted the versions-and-apps branch June 5, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants