Merged
Conversation
jost-s
approved these changes
Jul 29, 2024
Contributor
jost-s
left a comment
jost-s
left a comment
There was a problem hiding this comment.
I like the approach and agree. How can the shell hook be disabled?
Member
Author
Oh by disabled I mean "delete the line". Nothing fancy :) I just think it's much easier to find when it's in your flake, rather than trying to guess what inherited variable to assign an empty string to |
Contributor
|
Ah yes, of course. Cool! |
ThetaSinner
added a commit
that referenced
this pull request
Sep 2, 2024
* Fix concurrency logic * Use command instead of type for quiet output * Update Holonix versions on main (#30) * [create-pull-request] automated change * build --------- Co-authored-by: holochain-release-automation2 <100725712+holochain-release-automation2@users.noreply.github.com> Co-authored-by: ThetaSinner <ThetaSinner@users.noreply.github.com> * Add shell hooks (#31) * Run on PR * [create-pull-request] automated change (#33) Co-authored-by: holochain-release-automation2 <100725712+holochain-release-automation2@users.noreply.github.com> * [create-pull-request] automated change (#36) Co-authored-by: holochain-release-automation2 <100725712+holochain-release-automation2@users.noreply.github.com> * [create-pull-request] automated change (#37) Co-authored-by: ThetaSinner <6267702+ThetaSinner@users.noreply.github.com> * [create-pull-request] automated change (#38) Co-authored-by: holochain-release-automation2 <100725712+holochain-release-automation2@users.noreply.github.com> * feat: cargo build argument overrides for holochain (#35) * enable customized holochain builds * add custom build template * add hc-sandbox and hcterm * ci(build): add custom template * add template reference to flake * remove no-default-features from custom template * update holochain input * comment all binaries to build back in * Allow secret to be empty * Update Holonix versions on main (#39) * [create-pull-request] automated change * Bump hc-scaffold version * Update Lair --------- Co-authored-by: holochain-release-automation2 <100725712+holochain-release-automation2@users.noreply.github.com> Co-authored-by: Holochain Release Automation <hra+gh@holochain.org> Co-authored-by: ThetaSinner <ThetaSinner@users.noreply.github.com> * Exclude workflow call * [create-pull-request] automated change (#40) Co-authored-by: ThetaSinner <6267702+ThetaSinner@users.noreply.github.com> * Update Rust version and Nix packages * Add aarch64-linux (#41) * Point to main-0.3 * Ignore hcterm * Don't look for hcterm either --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: holochain-release-automation2 <100725712+holochain-release-automation2@users.noreply.github.com> Co-authored-by: ThetaSinner <6267702+ThetaSinner@users.noreply.github.com> Co-authored-by: Jost Schulte <jost.schulte@protonmail.com> Co-authored-by: Holochain Release Automation <hra+gh@holochain.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slightly different approach to previously. Adding this in the templates so that people can choose whether they want them or to change them. I have personally never liked my custom shell hook being overwritten and would want to be able to remove this. I think it should be there by default for people who are new to Holonix and they can make their own decisions later. It also helps reduce the amount of secret magic that happens with Holonix a bit.