test(kitsune): add integration test #100
Conversation
jost-s
force-pushed
the
test/add-kitsune-integration-test
branch
3 times, most recently
from
0c99c4b to
1faba6d
Compare
jost-s
force-pushed
the
test/add-kitsune-integration-test
branch
from
1faba6d to
3b51f46
Compare
crates/kitsune2/src/lib.rs
Outdated
| } | ||
|
|
||
| #[derive(Debug)] | ||
| struct HolochainSpaceHandler; |
There was a problem hiding this comment.
Would prefer to not have Holochain* names in here, hopefully we've done a reasonable job of decoupling here
| let (ops_2, op_ids_2) = create_op_list(100); | ||
| space_2 | ||
| .op_store() | ||
| .process_incoming_ops(ops_2.clone()) |
There was a problem hiding this comment.
Process incoming ops will make the ops available for "what's new" but there will be no DHT diff happening unless gossip is informed about these ops through the space with "inform_ops_stored". That will work fine for this test because all the ops are new. Just wanted to mention that.
There was a problem hiding this comment.
Yeah, I had that here but noticed it didn't make a diff(erence).
crates/kitsune2/src/lib.rs
Outdated
| let kitsune = kitsune_builder | ||
| .build(kitsune_handler.clone()) | ||
| .await | ||
| .unwrap(); | ||
| kitsune.space(TEST_SPACE_ID).await.unwrap() |
There was a problem hiding this comment.
You're dropping the top level kitsune instance here. We probably aren't cleaning everything up properly yet, but eventually this will shut everything down so your test won't work.
crates/kitsune2/src/lib.rs
Outdated
| }, | ||
| }) | ||
| .unwrap(); | ||
| kitsune_builder.op_store = MemOpStoreFactory::create(); |
There was a problem hiding this comment.
Don't replace a factory after you've already set the default config... you end up with a config for the wrong factory.
let mut kitsune_builder = Builder {
op_store: MemOpStoreFactory::create(),
..default_builder()
}.with_default_config().unwrap();There was a problem hiding this comment.
Also, the MemOpStoreFactory is the default, so you don't need to do this at all.
There was a problem hiding this comment.
running 1 test
test test::two_node_gossip ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 10.01s
I wish cargo test would give times for the individual tests. Luckily, since there's only one in there, we can see that it is 10s! Not entirely unreasonable.
Couple cleanup suggestions.
jost-s
force-pushed
the
test/add-kitsune-integration-test
branch
from
3b51f46 to
17f5adb
Compare
No description provided.