Revert " feat: display 'Player #' in logs to distinguish log messages from different Conductors" - #306
Merged
mattyg merged 1 commit intoOct 16, 2025
Conversation
… from di…" This reverts commit 20ee01b.
|
❌ Found 0 compliant commit and 1 non-compliant commits in 1c2db21. Commit 1c2db21 by @mattyg is not conform to the conventional commit specification :
This reverts commit 20ee01b.`
|
2 tasks
mattyg
added a commit
that referenced
this pull request
Oct 21, 2025
…eation and app install sequential (#303) * fix: avoid test failures due to apparant connection race condition -- start each player's conductor sequentially after a 1 second delay and adjust default k2Gossip configuration * chore: lint * docs: regenerate * chore: comment uniformity * test: update default config test * test: remove test that can no longer be achieved, since integration_limbo empties too quickly, instead cover assertions in success case test * chore: lint * test: remove test that can no longer be achieved, since integration_limbo empties too quickly, instead cover assertions in success case test * fix: reading ADMIN_PORT from conductor stdout was flaky * chore: changelog grammer * feat: display 'Player #' in logs to distinguish log messages from different Conductors (#302) * feat: display 'Player #' in logs to distinguish log messages from different conductors * feat: display 'Player #' in logs to distinguish log messages from different conductors * docs: rebuild docs * chore: grammer * fix: if addPlayersX is called multiple times, ensure that subsequently created players' label is incremented starting from number of existing players * chore: lint * chore: Revert " feat: display 'Player #' in logs to distinguish log messages from di…" (#306) This reverts commit 20ee01b. * revert: remove pause between conductor starts from addPlayers -- only need to stagger app installation as that initiates networking * chore: add TODO to comments explaining workaround * chore: clarifying comment * fix: clone rather than mutate map param * chore: lint * chore: removed TODO comment, which actually was not related to workaround * chore: unrelated typo * refactor: actually install apps sequentially, rather than via arbitrary pause * chore: lint * docs: clarify that addPlayerWithApp should not be called in parallel * chore: changelog * chore: changelog accuracy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #302