Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove direct pandas import #6476

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Dec 13, 2024

For now, to see what it would take not to do any direct imports of pandas.

This is doing the minimum effort. Probably, some of the functions that depend on pandas can be rewritten to not need to depend on it.

Import time comparison with Tuna (python -X importtime -c 'import holoviews' 2> tuna.log && tuna tuna.log):

After:
image

Before:
image

@hoxbro hoxbro force-pushed the remove_direct_pandas branch from 7fc6d1d to dc063df Compare December 13, 2024 16:26
@hoxbro hoxbro force-pushed the remove_direct_pandas branch from 0fa4a05 to af07d2f Compare February 21, 2025 13:09
@hoxbro hoxbro force-pushed the remove_direct_pandas branch from 0e81703 to dee9c00 Compare February 21, 2025 13:37
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 88.79%. Comparing base (01a80f2) to head (bf0402e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
holoviews/core/util/versions.py 73.68% 5 Missing ⚠️
holoviews/core/data/cudf.py 0.00% 3 Missing ⚠️
holoviews/core/data/pandas.py 90.47% 2 Missing ⚠️
holoviews/core/util/__init__.py 93.33% 2 Missing ⚠️
holoviews/core/util/types.py 96.66% 2 Missing ⚠️
holoviews/element/util.py 66.66% 2 Missing ⚠️
holoviews/element/graphs.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6476   +/-   ##
=======================================
  Coverage   88.79%   88.79%           
=======================================
  Files         323      325    +2     
  Lines       68940    69034   +94     
=======================================
+ Hits        61216    61302   +86     
- Misses       7724     7732    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro marked this pull request as ready for review February 21, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant