-
-
Notifications
You must be signed in to change notification settings - Fork 80
Support declaring a Parameterized class as an ABC #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b03b13b
start supporting ABC
maximlt 9db094f
Merge branch 'main' into abc_support
maximlt 0eca223
minor changes and more tests
maximlt 7b749c7
add docs
maximlt ed09b77
more docs
maximlt 887816a
expose ParameterizedABC in the top-level module
maximlt 0217b75
update import
maximlt f065a88
simplify match string
maximlt af3d7de
Merge branch 'main' into abc_support
philippjfr 25c7053
Merge branch 'main' into abc_support
maximlt 489a4cd
fix import
maximlt ce27b13
recommend not mixing the two approaches
maximlt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,5 +10,6 @@ | |
| :nosignatures: | ||
|
|
||
| Parameterized | ||
| ParameterizedABC | ||
| ParameterizedFunction | ||
| ``` | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is worth adding a follow on sentence to strongly recommend not mixing approaches? Having two inconsistent ways of checking if a class is abstract sounds like a recipe for confusion!
That said, maybe param could have a wrapper utility that tries
inspect.isabstract(class)first and if that returnsFalse, checks again the param way?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment added in ce27b13
Internally, we have the
_is_abstractfunction that does exactly that. I don't really want to make it public though:abstractproperty (that's documented too, I checked) that accounts for both approachesIf people feel strongly about it, we can add it in another release anyway.