-
-
Notifications
You must be signed in to change notification settings - Fork 80
Add .rx.set method #957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .rx.set method #957
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #957 +/- ##
=======================================
Coverage 88.12% 88.12%
=======================================
Files 9 9
Lines 4857 4859 +2
=======================================
+ Hits 4280 4282 +2
Misses 577 577 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| def ternary(condition, _): | ||
| return resolve_value(x) if condition else resolve_value(y) | ||
| return bind(ternary, self._reactive, trigger.param.value) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Remember to document :-)
maximlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philippjfr is this ready?
|
Are people ok with the linguistic ambiguity between "set" as a collection of items and "set" as "assign"? I find |
|
FWIW I'm fine with the naming of |
|
I like set because its the term used in React Docs. |
|
I'm ok with |
|
+1 on keeping |
|
Unrelated test failures. |
Implements #956