Skip to content

Conversation

@philippjfr
Copy link
Member

Implements #956

@codecov
Copy link

codecov bot commented Jul 28, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.12%. Comparing base (b95d476) to head (778a64d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #957   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files           9        9           
  Lines        4857     4859    +2     
=======================================
+ Hits         4280     4282    +2     
  Misses        577      577           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

def ternary(condition, _):
return resolve_value(x) if condition else resolve_value(y)
return bind(ternary, self._reactive, trigger.param.value)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Remember to document :-)

Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philippjfr is this ready?

@jbednar
Copy link
Member

jbednar commented Feb 17, 2025

Are people ok with the linguistic ambiguity between "set" as a collection of items and "set" as "assign"? I find .rx.assign to more obviously indicate the latter meaning, but it's maybe less guessable? I.e. if I think about what I want to do to assign a value, "set" is indeed the word I think of, but then when I encounter .rx.set, I'm not sure which of the two meanings it would be. Happy with whatever other people agree on...

@maximlt
Copy link
Member

maximlt commented Feb 17, 2025

FWIW I'm fine with the naming of .rx.set (.rx.pipe(set | list | ...) being I believe the correct way to cast).

@MarcSkovMadsen
Copy link
Collaborator

I like set because its the term used in React Docs.

@maximlt maximlt added this to the v2.3.0 milestone Aug 1, 2025
@maximlt
Copy link
Member

maximlt commented Sep 22, 2025

I'm ok with rx.set(). How about you @philippjfr?

@philippjfr
Copy link
Member Author

+1 on keeping .set

@maximlt
Copy link
Member

maximlt commented Sep 23, 2025

Unrelated test failures.

@maximlt maximlt merged commit de05dd1 into main Sep 23, 2025
14 of 17 checks passed
@maximlt maximlt deleted the rx_set branch September 23, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants