-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TotalConnect API change fix #136793
Open
austinmroczek
wants to merge
9
commits into
home-assistant:dev
Choose a base branch
from
austinmroczek:tcc_fix_auth
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
TotalConnect API change fix #136793
+43
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
has-tests
integration: totalconnect
small-pr
PRs with less than 30 lines.
by-code-owner
Quality Scale: No score
labels
Jan 29, 2025
andrewsayre
reviewed
Jan 29, 2025
joostlek
requested changes
Jan 29, 2025
tests/components/totalconnect/snapshots/test_alarm_control_panel.ambr
Outdated
Show resolved
Hide resolved
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
by-code-owner
cla-signed
has-tests
integration: totalconnect
Quality Scale: No score
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Updates total_connect_client to 2025.1.4 which updates certain authentication API calls due to changes on the TotalConnect servers. Update tests to adjust for new API calls during authentication.
Changelog for all changes since last version used in HA: craigjmidwinter/total-connect-client@2024.12...2025.1.4
Prior to the authentication problem, we were improving the typing in total_connect_client. We decided that various IDs should be strings, including partition_id. This is why partition_id changes to a string in alarm_control_panel, tests and snapshot files.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: