[DE] Add HassBroadcast #2882
Merged
[DE] Add HassBroadcast #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mib1185
requested changes
Jan 17, 2025
Co-authored-by: Michael <[email protected]>
Co-authored-by: Michael <[email protected]>
Co-authored-by: Michael <[email protected]>
you're right, we should not add the punctuation 😬 |
mib1185
reviewed
Jan 17, 2025
mib1185
reviewed
Jan 17, 2025
Co-authored-by: Michael <[email protected]>
andreasbrett
commented
Jan 17, 2025
mib1185
requested changes
Jan 17, 2025
auto-merge was automatically disabled
January 17, 2025 22:39
Pull request was converted to draft
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Michael <[email protected]>
mib1185
requested changes
Jan 17, 2025
mib1185
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DE version of #2877
@mib1185 @easterapps this needs fine tuning. suggestions very welcome. "verkünde, dass das abendessen fertig ist" would need to require a transformed response "das abendessen ist fertig" to be perfectly correct. unfortunately it's not as easy in DE as it is in EN. I could not find phrases that are as smooth as in EN.