ci: compare bundle size #3661
ci: compare bundle size #3661
Conversation
|
if this pr is merged,
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3661 +/- ##
=======================================
Coverage 91.69% 91.70%
=======================================
Files 159 159
Lines 10138 10145 +7
Branches 2976 2908 -68
=======================================
+ Hits 9296 9303 +7
Misses 840 840
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
Hi @m-shaka, could you please check this? |
This reverts commit 7861d1a.
|
Hi @k2tzumi! Can you review this, you too? |
| perf-measures-bundle-check-on-pr: | ||
| name: 'Bundle Check on PR' | ||
| runs-on: ubuntu-latest | ||
| if: github.event_name == 'pull_request' |
There was a problem hiding this comment.
q: Does the bundle size change every time?
Or does it change only when a specific file is changed?
Should I integrate workflow jobs when importing into #3491? Should we keep them separate? I am pondering.
There was a problem hiding this comment.
q: Does the bundle size change every time?
Or does it change only when a specific file is changed?
it change only when a specific file is changed is right.
Only when a core file is changed.
Should I integrate workflow jobs when importing into #3491? Should we keep them separate? I am pondering.
I have limited knowledge about it, sorry.
| - run: | | ||
| { | ||
| echo 'COMPARISON<<EOF' | ||
| ls -l ./generated | column -s '|' -t |
There was a problem hiding this comment.
It seems that it is not enough to simply parse the result of the ls command to get output like the following
https://github.com/honojs/hono/actions/runs/11818332808/job/32925651835?pr=3665#step:9:24
The column -s '|' -t command formats | delimited characters, so you need to pipe at least | delimited output
ex)
| | Current | Previous |
| --- | --- | --- |
| Files | 256 | 256 |
| Lines | 115024 | 115024 |
| Identifiers | 112049 | 112049 |
| Symbols | 243346 | 243346 |
| Types | 204684 | 204684 |
| Instantiations | 3044052 | 3044052 |
| Memory used | 422387K | 422692K |
| I/O read | 0.01s | 0.02s |
| I/O write | 0.00s | 0.00s |
| Parse time | 0.28s | 0.28s |
| Bind time | 0.11s | 0.11s |
| Check time | 2.40s | 2.42s |
| Emit time | 0.00s | 0.00s |
| Total time | 2.79s | 2.81s |
There was a problem hiding this comment.
thanks, any idea to format the output?
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code