You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On windows, statically linking libjpeg-turbo in release builds resulted in extremely poor performance relative the system-provided shared library. Inspecting the cmake output showed that there weren't any optimization flags specified. This should fix windows-specific performance, but it's also possible that all platforms have the same behavior.
When building for x86_64-unknown-linux-gnu on my system, I verified that the build script calls cmake with -DCMAKE_BUILD_TYPE=Release and that the generated Makefiles do build the static library with -O3. I don't have access to a Windows system at the moment, can you please check where this breaks on your system? In particular, does the build script call cmake with a correct -DCMAKE_BUILD_TYPE? (You can see the cmake arguments in the output of the build script, which you can see by invoking cargo with -vv)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On windows, statically linking libjpeg-turbo in release builds resulted in extremely poor performance relative the system-provided shared library. Inspecting the cmake output showed that there weren't any optimization flags specified. This should fix windows-specific performance, but it's also possible that all platforms have the same behavior.