Skip to content

feat: OpenAPI spec #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 14, 2025
Merged

feat: OpenAPI spec #315

merged 11 commits into from
Apr 14, 2025

Conversation

leggetter
Copy link
Collaborator

@leggetter leggetter commented Apr 4, 2025

TODO:

  • Identify payloads that change based on type
  • Add details for payloads based on type

@Copilot Copilot bot review requested due to automatic review settings April 4, 2025 17:22
Copy link

vercel bot commented Apr 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
outpost-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 0:03am
outpost-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 0:03am

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • docs/pages/overview.mdx: Language not supported
  • docs/pages/references/api.mdx: Language not supported
Comments suppressed due to low confidence (2)

docs/zudoku.config.ts:150

  • Ensure that changing the sidebar API entry from type 'doc' to type 'link' is intentional and that the new configuration integrates correctly with the navigation system.
          {

README.md:11

  • Confirm that the removal of the
    element does not adversely affect the intended layout or visual separation in the warning section.
-<br>

@leggetter
Copy link
Collaborator Author

leggetter commented Apr 4, 2025

@alexluong whilst creating the OpenAPI spec from the router, it seems that a lot of methods are mapped to the root of the API as well as /:tenantId. Which of these methods should we include in the OpenAPI spec and which should we hide as convenience methods? Or should we list everything for completeness?

See https://outpost-docs-git-feat-api-spec-hookdeck.vercel.app/docs/docs/api/health?_vercel_share=s3MpRPmywG67hbsA5fFUXoc59nGWElrx

Example for quick reference:

CleanShot 2025-04-04 at 20 11 58@2x

@leggetter leggetter mentioned this pull request Apr 4, 2025
@alexluong
Copy link
Collaborator

Hmm it's a bit tricky to say. The ones which are mapped to root & tenants are root, with tenant being a helper endpoint for the portal.
I think we can just document the root ones since you don't really need the tenant ones. If you'd like, you can also mention it in the description or something if that helps?

@leggetter leggetter added this to the Alpha-2 milestone Apr 10, 2025
@leggetter leggetter moved this from Backlog to In Progress in Outpost Releases Apr 10, 2025
@leggetter leggetter linked an issue Apr 10, 2025 that may be closed by this pull request
@leggetter leggetter merged commit 4802361 into main Apr 14, 2025
3 checks passed
@leggetter leggetter deleted the feat/api-spec branch April 14, 2025 12:13
@leggetter leggetter moved this from In Progress to Done in Outpost Releases Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Create OpenAPI Schema
2 participants