Skip to content

Conversation

alexluong
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Oct 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
outpost-docs Ready Ready Preview Comment Oct 6, 2025 10:20am
outpost-website Ready Ready Preview Comment Oct 6, 2025 10:20am

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances load testing capabilities by adding millisecond-precision timestamp support to destination metadata and fixing load test script status code expectations. The key improvements include infrastructure for more precise delivery latency measurements and corrected HTTP status code handling.

  • Added support for millisecond-precision timestamps in destination metadata via new timestamp-ms field
  • Fixed load test scripts to expect correct HTTP 202 status codes instead of 200
  • Updated all destination provider constructors to accept BasePublisherOption parameters

Reviewed Changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
loadtest/src/tests/events.ts Updated to expect 202 status code instead of 200
loadtest/src/tests/events-verify.ts Added millisecond timestamp header parsing support
loadtest/src/tests/events-throughput.ts Updated to expect 202 status code instead of 200
internal/destregistry/basepublisher.go Added millisecond timestamp support and BasePublisherOption configuration
internal/destregistry/baseprovider.go Updated to accept BasePublisherOption parameters
internal/destregistry/providers//dest.go Updated constructor signatures to accept BasePublisherOption
internal/destregistry/providers/default.go Added millisecond timestamp configuration to default provider registration
internal/config/destinations.go Added configuration option for millisecond timestamps
contributing/loadtest/overview.md Added comprehensive load testing documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alexluong alexluong merged commit 146bcc8 into main Oct 6, 2025
4 of 6 checks passed
@alexluong alexluong deleted the timestamp-ms branch October 6, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant