Skip to content

Fix titles#9197

Merged
abdrasulov merged 1 commit into
version/0.49from
fix-titles
May 13, 2026
Merged

Fix titles#9197
abdrasulov merged 1 commit into
version/0.49from
fix-titles

Conversation

@abdrasulov
Copy link
Copy Markdown
Contributor

@abdrasulov abdrasulov commented May 13, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Updated contact screen title to dynamically reflect current state instead of displaying static text.
    • Removed redundant title from markdown screen for improved interface clarity.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 22501364-1c88-4e57-b0d2-e5a4ee058704

📥 Commits

Reviewing files that changed from the base of the PR and between 2055c24 and adffa3c.

📒 Files selected for processing (2)
  • app/src/main/java/io/horizontalsystems/bankwallet/modules/contacts/screen/ContactScreen.kt
  • app/src/main/java/io/horizontalsystems/bankwallet/modules/markdown/MarkdownFragment.kt

📝 Walkthrough

Walkthrough

Two Compose screens update their scaffold titles: ContactScreen now dynamically reads the title from UI state instead of using a hardcoded string resource, while MarkdownFragment simplifies to an empty title and removes the corresponding unused import.

Changes

UI Scaffold Title Updates

Layer / File(s) Summary
ContactScreen dynamic title
app/src/main/java/io/horizontalsystems/bankwallet/modules/contacts/screen/ContactScreen.kt
HSScaffold title is now sourced from uiState.headerTitle.getString() instead of the static stringResource(R.string.CoinPage_Indicators).
MarkdownFragment empty title and cleanup
app/src/main/java/io/horizontalsystems/bankwallet/modules/markdown/MarkdownFragment.kt
HSScaffold title is set to an empty string, and the unused stringResource import is removed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Fix titles' is vague and generic, using non-descriptive language that doesn't convey what specific titles were fixed or which components were affected. Provide a more descriptive title that specifies which screen titles were fixed and what changed, such as 'Update ContactScreen and MarkdownFragment title handling' or 'Fix dynamic title loading in ContactScreen'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-titles

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@abdrasulov abdrasulov merged commit 33d8b4a into version/0.49 May 13, 2026
2 checks passed
@abdrasulov abdrasulov deleted the fix-titles branch May 13, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants