Build reports are not always needed #746
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Iabff6943c4c42ebda7423a34775087fb2d621289
…-20444) Change-Id: I07e743adfea5f6a1f639feb43ac1fe7c0cd96a88
Change-Id: Ia025ec5922de6ec81581c0eb46913bcf34697145
* Fix default toString for JsonProperties.NULL_VALUE The normalization of the Schema is inconsistent across restarts due to object's JsonProperties.NULL_VALUE lack of override toString. This fixes that and allows deterministic creation for fingerprints. * Assert that fingerprint hash remains the same across executions Added test case to assess that generated fingerprint is always the same between multiple executions, to prevent using an invalid stringified version of Object. Same Schema string must return same fingerprint, at least as long as normalize function is not changed. Forced MD5, just in case in future releases, the default hashing algorithm changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That report generation takes time, slowing down the overall build. Reports are definitely useful, but do you need them every time you run the build. We can conditionally disable generating test reports by setting
<disableXmlReport>true<disableXmlReport>. If you need to generate reports, just add-DcloseTestReports=falseto the end of mvn build command.=====================
If there are any inappropriate modifications in this PR, please give me a reply and I will change them.