Hide social links in footer using empty strings

[jacobwhall]

What type of PR is this? (check all applicable)

• 🍕 Feature
• 🐛 Bug Fix
• 📝 Documentation
• 🧑‍💻 Refactor
• ✅ Test
• 🤖 Build or CI
• ❓ Other (please specify)

Describe this PR

If a social link is set to an empty string, the icon itself will be hidden from the site's footer. Useful for downstream deployments which have different sets of socials 🫣

Screenshots

Alternative Approaches Considered

Maybe it would be better to specifically flag that a social link isn't used, rather than interpreting an empty string? This felt like a natural way to handle it.

Review Guide

It's most important that HOTOSM's social links remain intact in the default case. Which they should, because of the frontend/src/config/index.js settings. I tested this PR and there was no change to the icons until I modified one of the variables to be an empty string.

Checklist before requesting a review

• 📖 Read the Tasking Manager Contributing Guide: https://github.com/hotosm/tasking-manager/blob/develop/docs/developers/contributing.md
• 📖 Read the HOT Code of Conduct: https://docs.hotosm.org/code-of-conduct
• 👷‍♀️ Create small PRs. In most cases, this will be possible.
• ✅ Provide tests for your changes.
• 📝 Use descriptive commit messages.
• 📗 Update any related documentation and include any relevant screenshots.
• 🔠 Does this PR introduce or change any environment variables? If so, make sure to specify this change in the description.

[optional] What gif best describes this PR or how it makes you feel?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[suzit-10]

Thanks @jacobwhall for the suggestion! The code you suggested and the current implementation actually produce the same result, since we already filter out empty links with socialNetworks.filter(item => item.link) during rendering.

It looks like the changes in frontend/src/config/index.js (or other related files) might be missing from this PR, or I might be misunderstanding. Could you please confirm?

[jacobwhall]

It looks like the changes in frontend/src/config/index.js (or other related files) might be missing from this PR, or I might be misunderstanding. Could you please confirm?

That is intended behavior for this PR. In my downstream fork, I have further modifications of that config file to change these values to empty strings as necessary. I would be interested in contributing more of my modifications, if your team wishes, to make it easier for others to make adjustments.

It looks like the changes in frontend/src/config/index.js (or other related files) might be missing from this PR, or I might be misunderstanding.

In my testing, this was not the case. That filter function was keeping link values that were empty strings, such that the social icons were remaining on the homepage. I figured the easiest way to handle this was to remove empty values entirely from the socialNetworks array.

Could you please confirm?

Sure, I will re-test this PR and get back to you.

Thank you for your review!

[suzit-10]

Hi @jacobwhall, thanks again for the PR and the explanation 🙏

Would you be able to update frontend/src/config/index.js (or related config files) in this PR so the behavior matches the intended result (hiding empty social links)? This would ensure empty values are handled correctly.

Really appreciate your contributions! 🙌

[jacobwhall]

Sorry for my delay in getting back to you @suzit-10. With my latest commit, no social links appear by default, and must be specified using environment variables (or by editing frontend/src/config/index.js)